Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expr: fix nil panic for In function with bit column #33204

Merged
merged 4 commits into from
Mar 21, 2022
Merged

expr: fix nil panic for In function with bit column #33204

merged 4 commits into from
Mar 21, 2022

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Mar 17, 2022 •
edited
Loading

Signed-off-by: yisaer [email protected]

What problem does this PR solve?

Issue Number: close #33070

Problem Summary:

What is changed and how it works?

We left a code bug in #32898 which caused this panic. If all the args are negative number in In for bit column, we should return a corrected error message.

Check List

Tests

  • Unit test

Release note

None

@Yisaer
fix 33070
e7bdfbd 
Signed-off-by: yisaer <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 17, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • rebelice
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 17, 2022
@Yisaer
fix 33070
0872c0a 
Signed-off-by: yisaer <[email protected]>
@Yisaer
fix 33070
27865ec 
Signed-off-by: yisaer <[email protected]>
@sre-bot
Copy link
Contributor

sre-bot commented Mar 18, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/b2646612a37b5180ed27b9916da043b237fc30fe

@Yisaer Yisaer marked this pull request as ready for review March 18, 2022 04:54
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 18, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 21, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 21, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 27865ec

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 21, 2022
@ti-chi-bot
Copy link
Member

@Yisaer: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit f9beb51 into pingcap:master Mar 21, 2022
@lilinghai lilinghai mentioned this pull request Aug 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebelice rebelice rebelice approved these changes

@winoros winoros winoros approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/6.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

invalid memory address or nil pointer dereference
5 participants
@Yisaer @ti-chi-bot @sre-bot @winoros @rebelice